Skip to content

Improve commands #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Improve commands #301

wants to merge 4 commits into from

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Mar 12, 2015

No description provided.

@ns-bot
Copy link

ns-bot commented Mar 12, 2015

Test FAILed.

@rosen-vladimirov
Copy link
Contributor

It looks like you have to rebase :P
Anyway, with these changes run command will build your project and start it on the device (deployOnDevice method now starts the app).
deploy command uses directly deploy on device, so it will do exactly the same thing as run command for device.

Maybe this is the right time to fix this #293 ? What do you think - I suggest to remove deploy command and just make an alias of run commands for android and ios?

@rosen-vladimirov rosen-vladimirov added this to the v1.0 milestone Mar 12, 2015
@Fatme Fatme force-pushed the fatme/improve-commands branch from 1750f94 to 1bfed12 Compare March 17, 2015 10:50
@ns-bot
Copy link

ns-bot commented Mar 17, 2015

Test FAILed.

@Fatme
Copy link
Contributor Author

Fatme commented Mar 17, 2015

I totally agree with you and will implement it in this PR.

@Fatme Fatme force-pushed the fatme/improve-commands branch from 1bfed12 to d216e29 Compare March 17, 2015 11:00
@ns-bot
Copy link

ns-bot commented Mar 17, 2015

Test PASSed.

@Fatme Fatme closed this May 15, 2015
@Fatme Fatme deleted the fatme/improve-commands branch October 15, 2015 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants